Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenSubtitles - Subtitles support #3904

Open
opensubtitles opened this issue Jan 19, 2024 · 12 comments
Open

OpenSubtitles - Subtitles support #3904

opensubtitles opened this issue Jan 19, 2024 · 12 comments

Comments

@opensubtitles
Copy link

Hi guys,

we are receiving quite a lot of request, how to make opensubtitles work again in Enigma. we announcement EOL of old API, please read this:

https://forum.opensubtitles.org/viewtopic.php?t=17930#p47873

Either allow users to use opensubtitles.org username and password, or better, implement API of opensubtitles.com

Thank you

@WanWizard
Copy link
Member

Thanks for the headsup. But afaik, we don't use opensubtitles anywhere. Perhaps a third-party plugin?

@opensubtitles
Copy link
Author

I am not sure, we just receive questions how to enable subtitles again. If you can find out which plugin is using our services, it would be great, so I can contact them directly, but I guess it is not maintained anymore...

@WanWizard
Copy link
Member

WanWizard commented Jan 20, 2024

I've posted a notice on our forum: https://forums.openpli.org/topic/97560-opensubtitles/

There is a lot of junk out there that is not maintained anymore, but as most of these plugin builders don't make their source public so we can build from it, but create binaries they float on different forums, it is difficult to do anything once they're out.

@jbleyel
Copy link

jbleyel commented Jan 20, 2024

Hello @opensubtitles , we are planning to use this new repro. I have started this but it‘s not finished:

https://github.com/oe-alliance/subssupport

@popking159
Copy link

Hello @opensubtitles , we are planning to use this new repro. I have started this but it‘s not finished:

https://github.com/oe-alliance/subssupport

I want to help get this plugin back to life , I made some modifications to subtitles providers , you can try it and add it to the feed , of course it is not finished but it works and will help download and play external subtitles.

https://www.mediafire.com/file/v9c4y4k7fl9rybb/enigma2-plugin-extensions-subssupport_1.7.0-r10-py3_all.ipk/file

@jbleyel
Copy link

jbleyel commented Nov 25, 2024

Can you please make a pull request here ->

https://github.com/oe-alliance/subssupport

@opensubtitles
Copy link
Author

@popking159 good job. Did you implement new API, or it is using old one with username and password ?

@jbleyel
Copy link

jbleyel commented Nov 25, 2024

Hello @popking159 , your changes are probably working but your code needs a cleanup.
I have compared your code with my last version and you have a lot of issues what I have already fixed.

@popking159
Copy link

Hello @popking159 , your changes are probably working but your code needs a cleanup. I have compared your code with my last version and you have a lot of issues what I have already fixed.

Yes I know , as I said , it is not finished but it works .
Thanks for help

@popking159
Copy link

@popking159 good job. Did you implement new API, or it is using old one with username and password ?

Scraping only , no need for API or username

@littlesat
Copy link
Member

littlesat commented Nov 26, 2024

Scraping is not the way you should do it.
API is the way
A small change on the website stop scraping or needs another change more frequently.

@opensubtitlesdev
Copy link

opensubtitlesdev commented Nov 26, 2024

@popking159 good job. Did you implement new API, or it is using old one with username and password ?

Scraping only , no need for API or username

I'm the main developer of the opensubtitles.com site and API, I jump in....

Sorry that's really not a viable option, you can't authenticate, you'll be limited to 10 subtitles per day, and have to deal with the download delay. plus all the routing for the search will be changed soon, so it will definitely not work for long.

the API is free, it's documented, it gives you full access to the content, an so much more.....

so I'm sorry but this need an entire rewrite using the API https://opensubtitles.stoplight.io/docs/opensubtitles-api/ we're around and happy to help if you have questions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants