Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is there a cleaner API for getting feedback about a connection attempt? #12

Open
MoralCode opened this issue Apr 27, 2022 · 1 comment · May be fixed by #17
Open

Is there a cleaner API for getting feedback about a connection attempt? #12

MoralCode opened this issue Apr 27, 2022 · 1 comment · May be fixed by #17
Labels
API enhancement New feature or request

Comments

@MoralCode
Copy link
Collaborator

Currently the connect() and disconnect() methods on Ergometer return void and the consumer of this api needs to subscribe to changes in connection state via monitorConnectionState to see if it worked or not.

Goal:
It would be nice to find a way to provide feedback (even a simple binary true/false) when people call these connection methods as an indication of success or failure.

Possible issues
This might need to wait until after #6 since things might change

@MoralCode MoralCode added enhancement New feature or request API labels Apr 27, 2022
@MoralCode
Copy link
Collaborator Author

this is resolved in #17. flutter_reactive_ble has the connect function return a stream of status data that can be closed to disconnect. a much cleaner API than what we had before

@MoralCode MoralCode linked a pull request Nov 16, 2022 that will close this issue
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant