Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CloudWatch SLI causes error when converting #183

Open
ian-bartholomew opened this issue Dec 13, 2022 · 1 comment · Fixed by #184
Open

CloudWatch SLI causes error when converting #183

ian-bartholomew opened this issue Dec 13, 2022 · 1 comment · Fixed by #184
Assignees
Labels
bug Something isn't working

Comments

@ian-bartholomew
Copy link
Contributor

Summary

when unmarshaling CloudWatch data, the sequence nodes are getting improperly unmarshaled, causing an error when running olso convert

Steps to reproduce

Given file sli.yaml:

apiVersion: openslo/v1
kind: SLI
metadata:
  name: foo-sli
spec:
  description: string # optional up to 1050 characters
  thresholdMetric: 
    metricSource:
      metricSourceRef: foo-cloudwatch
      type: CloudWatch
      spec:
        metricName: 2xx
        namespace: CloudWatchSynthetics
        region: us-east-1
        stat: SampleCount
        dimensions:
          - name: following
            value: bar

run oslo convert -f sli.yaml -o nobl9

What is the current bug behavior?

This will cause an error

What is the expected correct behavior?

The yaml should be correctly parsed and the nobl9 yaml produced

@ian-bartholomew
Copy link
Contributor Author

Seeing that this might not have solved for all use cases so reopening

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant