Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Automatic Approval for OpenSPP Self-Reg Change Requests #635

Open
gonzalesedwin1123 opened this issue Oct 21, 2024 · 1 comment · May be fixed by #653
Open

Add Automatic Approval for OpenSPP Self-Reg Change Requests #635

gonzalesedwin1123 opened this issue Oct 21, 2024 · 1 comment · May be fixed by #653
Assignees

Comments

@gonzalesedwin1123
Copy link
Member

gonzalesedwin1123 commented Oct 21, 2024

Add a function to the Change Request module that will be used by the OpenSPP Self-Reg. The submission of Change Requests (CRs) from OpenSPP Self-Reg will be processed as follows:

  • Accept CRs only from users belonging to the "Change Request External API" group.
  • Validate the CR input data.
  • Skip the validation of required attachments.
  • Automatically approve the CR after the input data has been validated.

With this new function the submissions of CRs will have the following results:

  1. CRs from the OpenSPP Self-Reg submitted by users of the "Change Request External API" group will be automatically approved upon execution of the validation of input data.
  2. All other CRs will follow the standard validation and approval process.
@jannahadlaon
Copy link

Findings: Return to dev
Ticket is still in progress. Need to add fix to other CR Request Types.

Below are the steps on how Add Farmer CR Request Type was verified.
STEPS:

  1. Import postman collection from dev in postman
  2. Add Farmer Change Request
  3. Send a Create Request Detail - Farmer Request using the result from step 2 - this will create an empty farmer.
  4. Check res_id from step 3, use it in the Modify Farmer Request to update the farmer data.
  5. Using the result from step 2, Approve CR
  6. Log in as admin in HDM instance and verify that the CR is approved and applied.

cc: @jay-anneb @gonzalesedwin1123 @megaxayda

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants