Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor logic of chainID and chainIdentifier. #195

Open
0xsarvesh opened this issue Oct 23, 2019 · 0 comments
Open

Refactor logic of chainID and chainIdentifier. #195

0xsarvesh opened this issue Oct 23, 2019 · 0 comments

Comments

@0xsarvesh
Copy link
Contributor

Mosaic chains supports readable chain identifier like ropsten, ethereum etc for origin chain. However, different part of code requires chainID for instance deployment of anchor needs remoteChainID which is uint256.

For developer, it's a pain point and confusing what originChain means. Both chainIdentifier and chainID is required in the codebase.

This ticket is about defining and implementing a clear approach to keep both terminology.

Possible approach: Code should only use chainIDs everywhere and at commander layer chain Identifiers should be converted to chainIds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant