Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Groups #343

Open
AlexisMignon opened this issue Apr 15, 2022 · 0 comments
Open

Feature Groups #343

AlexisMignon opened this issue Apr 15, 2022 · 0 comments
Labels
feature engineering feature New feature or request

Comments

@AlexisMignon
Copy link
Collaborator

WHAT:
Some features come in groups. For instance, calendar features, holidays, cyclic features, ... It should be possible to add group of features without having to enumerate them in the feature_names.

HOW:
Add a new FeatureGroupAdder object deriving from FeatureAdder, which declares a list of features that can be built. They can be activated by either asking for a subgroup of the managed features (as for the classic feature adders) or by indicated a group name.

For instance, to add holidays, we could have:

modelspecs.feature_names = [..., "is_christmas", ...]

to have only the Christmas day indicator, or

modelspecs.feature_names = [..., "holidays_uk", ...]

An easy way to deal with this would be as a first step in the FeatureDispatcher to detect group names, replace the group name in feature_names by the corresponding features and then use the usual feature addition mechanism.

TEST:
Test that adding a group name leads to an actual list including all the features of the group.

@AlexisMignon AlexisMignon added feature New feature or request feature engineering labels Apr 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature engineering feature New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant