Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistency in r_mea_highest metric #543

Open
wnederpel opened this issue Jul 24, 2024 · 0 comments
Open

Inconsistency in r_mea_highest metric #543

wnederpel opened this issue Jul 24, 2024 · 0 comments

Comments

@wnederpel
Copy link

The documentation of the r_mae_highest metric reads:

openstef.metrics.metrics.r_mae_highest(realised, forecast, percentile=0.95)

Function that calculates the relative mean absolute error for the 5 percent highest realised values.

The range is based on the load range of the previous two weeks.

The default argument for the percentile seems to be inconsistent with the documentation and should be 95 instead of 0.95 to compute the error for the highest 5 percent of realised values (numpy and pandas interpret the percentile argument differently) .

In addition I believe the sentence "The range is based on the load range of the previous two weeks." to be confusing and no longer up to date with the code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant