From 9f3914dff64cab93a7a06f5bfb930f6e5ef14f06 Mon Sep 17 00:00:00 2001 From: Frank Kreuwel Date: Fri, 11 Aug 2023 16:49:55 +0200 Subject: [PATCH 1/3] remove incorrect report creation Signed-off-by: Frank Kreuwel --- openstef/pipeline/optimize_hyperparameters.py | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/openstef/pipeline/optimize_hyperparameters.py b/openstef/pipeline/optimize_hyperparameters.py index 8289133a8..5af9f9c94 100644 --- a/openstef/pipeline/optimize_hyperparameters.py +++ b/openstef/pipeline/optimize_hyperparameters.py @@ -209,17 +209,14 @@ def optimize_hyperparameters_pipeline_core( # Train a model using the regular train pipeline. # The train/validation/test split used in hyperparam optimisation # is less suitable for an operational model. - best_model, report, modelspecs, _ = train_model_pipeline_core( + model, report, model_specs, _ = train_model_pipeline_core( pj=pj, input_data=input_data, model_specs=model_specs ) - # Save model and report. Report is always saved to MLFlow and optionally to disk - report = objective.create_report(model=best_model) - trials = objective.get_trial_track() best_trial_number = study.best_trial.number - return best_model, model_specs, report, trials, best_trial_number, study.best_params + return model, model_specs, report, trials, best_trial_number, study.best_params def optuna_optimization( From 6f71fac180d58c82afcbaca9201e2d7b9a097157 Mon Sep 17 00:00:00 2001 From: Frank Kreuwel Date: Fri, 11 Aug 2023 16:58:33 +0200 Subject: [PATCH 2/3] remove unused variable Signed-off-by: Frank Kreuwel --- openstef/pipeline/optimize_hyperparameters.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/openstef/pipeline/optimize_hyperparameters.py b/openstef/pipeline/optimize_hyperparameters.py index 5af9f9c94..fa749ebe3 100644 --- a/openstef/pipeline/optimize_hyperparameters.py +++ b/openstef/pipeline/optimize_hyperparameters.py @@ -188,7 +188,7 @@ def optimize_hyperparameters_pipeline_core( ) best_hyperparams = study.best_params - best_model = study.user_attrs["best_model"] + # the best_model could be accessed via study.user_attrs["best_model"] logger.info( f"Finished hyperparameter optimization, error objective {study.best_value} " From c54893655399f3802a1532d179959e364c03eb34 Mon Sep 17 00:00:00 2001 From: Frank Kreuwel Date: Mon, 14 Aug 2023 08:45:12 +0200 Subject: [PATCH 3/3] Update openstef/pipeline/optimize_hyperparameters.py Co-authored-by: Jan Maarten van Doorn <52956303+JanMaartenvanDoorn@users.noreply.github.com> Signed-off-by: Frank Kreuwel --- openstef/pipeline/optimize_hyperparameters.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/openstef/pipeline/optimize_hyperparameters.py b/openstef/pipeline/optimize_hyperparameters.py index fa749ebe3..75340fd9f 100644 --- a/openstef/pipeline/optimize_hyperparameters.py +++ b/openstef/pipeline/optimize_hyperparameters.py @@ -188,7 +188,7 @@ def optimize_hyperparameters_pipeline_core( ) best_hyperparams = study.best_params - # the best_model could be accessed via study.user_attrs["best_model"] + # The best_model could be accessed via study.user_attrs["best_model"] logger.info( f"Finished hyperparameter optimization, error objective {study.best_value} "