Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SolrJ extension for SolrTextTagger #52

Open
westei opened this issue Jul 14, 2016 · 4 comments
Open

SolrJ extension for SolrTextTagger #52

westei opened this issue Jul 14, 2016 · 4 comments
Labels

Comments

@westei
Copy link
Contributor

westei commented Jul 14, 2016

Hi all,

Not really an issue, but I wanted to let you know that I implemented SolrParams, SolrRequest and SolrResponse specific for the SolrTextTagger.

The module is available at https://github.com/redlink-gmbh/solrj-text-tagger/
I plan to make it available at Maven Central in the coming days.

Feedback welcome!

best
Westei

@dsmiley
Copy link
Member

dsmiley commented Jul 17, 2016

Very cool! After we switch to Java 8 (which I see this code requires as it uses .stream()), what do you think of providing this code with the text tagger? It would probably result in another module but I think that's better than separate projects altogether.

@westei
Copy link
Contributor Author

westei commented Jul 18, 2016

I should definitely be an own module (as it only depends on SolrJ and does not have a direct dependency to the SolrTextTagger module. I have no problem of managing it at the above location, but maybe SolrTextTagger user will more likely find it when it is made available under the same groupId as the solr-text-tagger.

Regarding Java 8: I was in the impression that Solr 6 requires Java 8. In SolrJ they renamed some of the main classes with Solr 6. So to support older Java versions one would need to provide two separate releases (one for SolrJ 6 and SolrJ 5)

@dsmiley
Copy link
Member

dsmiley commented Jul 20, 2016

I just released 2.3 and bumped the tagger to Solr 6 and Java 8.

Yes, Solr 6 requires Java 8.
Feel free to send a pull request for this contribution. Perhaps the SolrJ module can be a child of the existing one, without having to move the current code to a new subdirectory -- that'd be nice.

@dsmiley
Copy link
Member

dsmiley commented Jun 29, 2018

Now that Solr 7.4.0 includes the tagger, perhaps you might want to propose your addition directly to Apache Solr / SolrJ.

@dsmiley dsmiley added the other label Jun 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants