Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TeamComments extension] Delete comments associated with a page along with the page? #10

Open
kfogel opened this issue Oct 26, 2019 · 1 comment

Comments

@kfogel
Copy link
Member

kfogel commented Oct 26, 2019

In the TeamComments extension, we should consider hooking into the MediaWiki page deletion API so that the comments associated with a given page are deleted when that page is deleted.

Filing a ticket so we don't forget to think about this (see the "Action items" section in the 2019-10-24 meeting notes.

@kfogel kfogel changed the title [TeamComments extension] Hook into MediaWiki page deletion API so associated comments are deleted when page is? [TeamComments extension] Delete comments associated with a page along with the page? Oct 26, 2019
@frankduncan
Copy link
Collaborator

One thing that makes this need more discussion is that mediawiki supports restoring pages, which then returns the page to the previous ID. When that happens, the current TeamComments functionality restores the comment chain as it was.

So the choice in front of us is:

  • Keep current functionality. The risk is bloated DB (not a big risk), and comment aggregation pages need to be aware that comments may be linked to pages that are dead
  • Delete comments when pages is deleted, and just lose them if page is restored.
  • Mirror what mediawiki does, and hook into both delete and restore actions, and have a secondary table where "deleted comments" live.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants