Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Torque errors on upload #64

Open
slifty opened this issue Nov 3, 2021 · 5 comments
Open

Torque errors on upload #64

slifty opened this issue Nov 3, 2021 · 5 comments
Labels
bug Something isn't working

Comments

@slifty
Copy link
Contributor

slifty commented Nov 3, 2021

When I run ETL I'm seeing a few hundred errors in my torque logs similar to:

image

(one error per upload)

@slifty slifty added the bug Something isn't working label Nov 3, 2021
@slifty
Copy link
Contributor Author

slifty commented Nov 3, 2021

I don't know if this is related, but I also see a ton of messages like this:

image

@frankduncan
Copy link
Collaborator

The first message is weird. What are the parameters that are being passed in? Some debugging will help.

The second message is mediawiki attempting to render the page when you do something to it (like edit it via the etl pipeline that creates all the pages). I have waffled between keeping this error message around because it's the same one (and very useful) if something is messed up with a users permissions, and removing it because anytime we upload, mediawiki tries and renders the page (for search caching, among other things) with no user group.

@slifty
Copy link
Contributor Author

slifty commented Nov 3, 2021

@frankduncan got it -- will debug around the first.

Re the second, I think the right thing here would be to figure out a way to have that message NOT appear when the system is behaving as expected (e.g. during ETL) but still appear when the system is not behaving. Is there a way to modify ETL to make sure the proper information is passed, or some other indicator that would prevent the warning from triggering?

@frankduncan
Copy link
Collaborator

@slifty Yeah, we coudl disable the #tdcrender tag when the user is on a specific block list, and we could do things like add the bots we use for ETL to that. That might be good enough. The only thing we'd need is a global variable in torque that says "hey, don't render when this is set" and let script set it.

@frankduncan
Copy link
Collaborator

The first is actually caused a bug I introduced when uplaoding new attachments. Pushing a fix to main now (as it also broke production)

frankduncan pushed a commit that referenced this issue Nov 4, 2021
This was because the permissions field is needed in the initial creation
of the Attachment object, and then needs to be set when being
overwritten.

Issue #64: Torque errors on upload
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants