Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move GitHub API access tokens to a header? #177

Open
jimallman opened this issue May 20, 2020 · 1 comment
Open

Move GitHub API access tokens to a header? #177

jimallman opened this issue May 20, 2020 · 1 comment
Assignees
@mtholder @jimallman

Comments

@jimallman
Copy link
Member

jimallman commented May 20, 2020 •
edited
Loading

It looks like we pass along an API user's token on the query string (via params), but I think this is deprecated and may stop working in late 2020, or even sooner during scheduled "brownouts".

It appears all of these calls are routed through our API wrapper, and ultimately forced through a single bottleneck in _WSWrapper._do_http. Maybe we could take this opportunity to examine params and move any auth_token value from there to an Authorization: token $TOKEN header added to _JSON_HEADERS.
jimallman added a commit that referenced this issue May 20, 2020
@jimallman
UNTESTED - moving auth token to header
aaef753 
This code is untested! but seems like it would do the right things.
Addresses #177.
@jimallman
Copy link
Member Author

I've added a quick sketch that might do the job, but it needs testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mtholder mtholder

@jimallman jimallman

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mtholder @jimallman