-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
should migrate to Enum class #62
Comments
This migration to enum34 was done some time ago, and it's been problematic. Now in testing devtree, it seems our pinned version 1.1.8 is no longer working (doesn't expose module deploy@ip-172-30-1-156:~/venv_web2py$ bin/python
Python 2.7.18 (default, Mar 8 2021, 13:02:45)
...
>>> import peyotl
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "/home/deploy/repos/peyotl/peyotl/__init__.py", line 30, in <module>
from peyotl.phylo.entities import OTULabelStyleEnum
File "/home/deploy/repos/peyotl/peyotl/phylo/entities.py", line 2, in <module>
from enum import Enum
ImportError: No module named enum
>>>
deploy@ip-172-30-1-156:~/venv_web2py$ bin/pip show enum34
...
Name: enum34
Version: 1.1.8 Upgrading According to the original |
hmmm. Frustrating. In particular because It looks like https://pypi.org/project/enum/#description might be the most lightweight replacement as it bills itself as a way to make code more robust. But I suspect that |
There are some "fake" enum classes in peyotl. I just found out that you can import py3 enums in py2.7 with the enum34 package.
We should migrate to using that for the sake of internal consistency.
The text was updated successfully, but these errors were encountered: