Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

should migrate to string interpolation in logger functions #82

Open
mtholder opened this issue Dec 8, 2014 · 0 comments
Open

should migrate to string interpolation in logger functions #82

mtholder opened this issue Dec 8, 2014 · 0 comments
Labels
enhancement low-priority

Comments

@mtholder
Copy link
Member

mtholder commented Dec 8, 2014

reinstating pylint W1202 will point these out, but it is pretty minor concern. So for now that warning is disabled to cut down on the noise.
mtholder added a commit that referenced this issue Dec 8, 2014
@mtholder
Silence (on module level) warning
1a4606f 
logging used % style string formatting, and pylint
warns about passing in args to logging function (to eliminate the
cost of string interpolation when the log message will not be emitted).

We're not worried about this extra cost right now.
See #82
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement low-priority
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mtholder