Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-locate nudge study index #239

Open
snacktavish opened this issue Jul 7, 2023 · 4 comments
Open

Re-locate nudge study index #239

snacktavish opened this issue Jul 7, 2023 · 4 comments

Comments

@snacktavish
Copy link
Member

Phylesystem github webhook needs somewhere to go. Maybe recode https://github.com/OpenTreeOfLife/phylesystem-api/blob/before-pyr/controllers/search.py#L57 directly into otindex?

@snacktavish
Copy link
Member Author

snacktavish commented Jul 10, 2023

I am porting this code over to be housed in otindex to receive the webhook directly. Working on branch https://github.com/OpenTreeOfLife/otindex/tree/webhook

I'm not sure how to trigger clearing the cache though. @jimallman - any thoughts?

api_utils.clear_matching_cache_keys(".*find_studies.*")

@jimallman
Copy link
Member

Damn, I should have caught that. Maybe cache-clearing was the rationale for having the initial webhook handler on phylesystem-api.

I assume we don't want to bind these two services to a single machine, so a remote cache-clearing method should do the trick. I can add a (undocumented/utility) method for this to the API.

@jimallman
Copy link
Member

Also, I'm planning to move the add-webhook functionality from a shell-script in phylesystem-api, to the Ansible playbook that deploys it.

@snacktavish
Copy link
Member Author

Sounds good. I realized there is supposed to be a webhook for the amendments as well... and there needs to a be destination for that one too. Likely in otindex directly as well, I think, unless this caching stuff means that you think we should still route them through phylesystem-api, as they used to be.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants