Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter subcategory dropdown according to profile selected in profile indicator admin #257 #267

Closed
wants to merge 14 commits into from

Conversation

goyal1092
Copy link
Collaborator

@goyal1092 goyal1092 commented May 10, 2021

Description

It was working on staging but not on production so I created a new commit according to current code of stable branch 0.13.0
Also found a bug in authentication which prevented the super user to fetch api results for private profile.
Added SessionAuthentication in config to resolve authentication problem.

Related Issue

#257

How to test it locally

Go into Profile Collection in admin panel and select profile.
Before selecting profile Subcategories dropdown should be empty.
It should send a ajax request to api for fetching subcategories for the profile.
Subcategories dropdown should have filtered options now

Changelog

  • Added a js file
  • Added get_form method in profile indicator admin
  • Changed view of profile api ProfileSubcategoriesList to return all subcategories linked to a profile
  • Added a new url
  • Added SessionAuthentication in config.

Added

Updated

Removed

Checklist

  • 🚀 is the code ready to be merged and go live?
  • 🛠 does it work (build) locally

Pull Request

  • 📰 good title
  • 📝good description
  • 🔖 issue linked
  • 📖 changelog filled out

Commits

  • commits are clean
  • commit messages are clean

Code Quality

  • 🚧 no commented out code
  • 🖨 no unnecessary logging
  • 🎱 no magic numbers
  • black was run locally (as part of the pre-commit hook)

Testing

  • ✅ added (appropriate) unit tests
  • 💢 edge cases in tests were considered
  • ✅ ran tests locally & are passing

@goyal1092
Copy link
Collaborator Author

Already working on staging

@goyal1092 goyal1092 closed this May 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant