Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub Webhooks get 403 response #1704

Closed
ghostscript3r opened this issue Feb 4, 2020 · 3 comments
Closed

GitHub Webhooks get 403 response #1704

ghostscript3r opened this issue Feb 4, 2020 · 3 comments

Comments

@ghostscript3r
Copy link

Hi, I'm pushing a new version of both my scripts, https://github.com/ghostscript3r/poe-trade-enhancer and https://github.com/ghostscript3r/poe-trade-official-site-enhancer as https://openuserjs.org/users/ghostscript3r

All previous release were updated with webhooks without a problem and settings haven't been changed (https://openuserjs.org/github/hook, application/json
application/x-www-form-urlencoded and I use only master branch). Last release 4 days ago returned 403 error response. I tryed manually to resend the push and I still get 403.
The response body is empty, so I have no idea what to check next. I searched similar issues but they all seem related to using branch different from master, and that's not my case.

Also the same update was successful on GreasyFork (no webhook though) so I'd say it shouldn't be a problem with the script itself.

@ghostscript3r
Copy link
Author

Looking better, the payload was with "ref": "refs/tags/v1.3.379" instead of master, even if I have just one branch. "v1.3.379" is just a tag created with release function in github. I don't have any idea why the webhook didn't start with the push to master and instead started after tagging. An error message in the body of the response would help a lot though.

@Martii
Copy link
Member

Martii commented Feb 5, 2020

@ghostscript3r

As I've mentioned at least once before the webhook routine takes a "list" and only acknowledges if it's been accepted or not. Keeping an open connection to GH, for any individual file sync's, can be a DoS vector and is discouraged in most circles even outside of GH.

There are some changes in progress on GH that may make things break with OUJS code and referenced at #1705 #1432 so you may have encountered a hiccup from them regarding some of their changes. I'm running a webhook retest momentarily.

Martii added a commit to Martii/UserScripts that referenced this issue Feb 5, 2020
@Martii
Copy link
Member

Martii commented Feb 5, 2020

Currently passing at RFC 2606§3 - Hello, World!

@OpenUserJS OpenUserJS locked as resolved and limited conversation to collaborators Apr 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

No branches or pull requests

2 participants