Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cookbook: review & update Contributing section #262

Open
7 tasks
stefaniebutland opened this issue Jun 30, 2023 · 5 comments
Open
7 tasks

Cookbook: review & update Contributing section #262

stefaniebutland opened this issue Jun 30, 2023 · 5 comments
Assignees

Comments

@stefaniebutland
Copy link
Member

stefaniebutland commented Jun 30, 2023

Review and update Contributing section.

Minimize duplication. Where possible, point to Approach Guide or Quarto website tutorial when info applies across multiple areas.

Notes from discussion w Julie Jun 22:

  • Focus on the technical
  • Are screenshots up to date? Things inright order?
  • Note that Ziheng didn’t know how to contribute a notebook till he saw the Workflow section
  • Where should it say “edit the _quarto.yml” to make it appear in nav bar
  • First it should say “here’s how to contribute” - make it clear that anyone can contribute - here’s how, then Cookbook setup, Workflow; move Mentors lower
  • Setup - is this the right order?
  • Workflow - update Quarto intro text
  • Do not worry about scope of cookbook - what we want and what we don’t want. This will come after retreat - come from the Mentors. Can add a section “Scope of cookbook - coming soon”

Audience:

Primary audience is NASA Mentors. This is why the Onboarding Mentors chapter currently comes first. This can be moved.

Write as if showing one of them and it will work for others too. People wondering how do I recall how to make a PR; someone who needs to learn GitHub now; needs a refresher; someone who has never used GitHub, Quarto, Hub…

Checklist

This list will be edited as tasks are defined.

First add:

  • How to contribute a chapter
  • How to review and merge a PR
    • combine with / edit Notebook Review
  • Intro: don't add explicit TOC, but note folks can find How to contribute a chapter and How to review and merge a PR
  • Point to Makhan’s tutorial setup with screenshots. Step 1. Login to the Hub is most helpful.
  • Point to Julie’s video in Cookbook Setup: Part 3:2i2c JupyterHub (video) introduces a beginning GitHub workflow from our 2i2c JupyterHub.
  • Do we already have “how to edit this page, click here to fix typo”?

Then:

  • Add some orientation to intro of Contributing - teaches you the technical and social decision making/ philosophy.

  • Workflow intro text - Prob can leave it for now. Julie’s good with the headings

  • Maybe delete Virtual Envts
    This popout - Summary of GitHub and Quarto commands detailed below - is really good when quickly finding a command

  • Notebook Review

    • Check what’s there -> Review with .qmds was Julie being opinionated. Either leave it….or …not?
    • The git button in JupyterHub is newish thanks to Eli; before then it was all cmd line. Julie wrote the above before the button was there
@stefaniebutland stefaniebutland self-assigned this Jun 30, 2023
@stefaniebutland stefaniebutland changed the title Cookbook update Contributing Cookbook review & update Contributing section Jun 30, 2023
@stefaniebutland
Copy link
Member Author

stefaniebutland commented Jul 3, 2023

Contributing text written for perspective of a NASA Openscapes Mentor accessing Cookbook in Openscapes 2i2c JupyterHub

Assumptions

  • review of pull request is required for merging

Questions

  • can/should someone push to main to fix a typo or do they use pull request workflow?

The Doing

  • What do I need to get started? This is in Cookbook Setup
    • GitHub and JupyterHub logins
    • info on how book is made e.g. Quarto
  • How do I fix a typo?
    • work in GitHub browser, edit file, commit to a new branch, make pull request, (how/who to tag someone to review?)
  • How do I edit a chapter?
    • work locally, in a branch, edit file, render to preview, commit
    • make pull request, get a review
  • How do I add a new chapter?
    • level 2 header in Workflow, after Cookbook Practices, before Notebook Review
    • define chapter cause just adding a subsection doesn't require editing _quarto.yml
    • work locally, in a branch, create new chapter file, edit, render to preview, edit _quarto.yml to indicate where chapter will appear in nav bar, render to preview
    • make pull request, get a review
  • How do I review and merge a pull request?
    • combine with / edit Notebook Review
    • 🤔 see Workflow: GitHub Workflow: Pull Request; seems like it goes there
    • I think we have videos for this: Julie & Cassie?, Stef & Julie

@stefaniebutland stefaniebutland changed the title Cookbook review & update Contributing section Cookbook: review & update Contributing section Jul 3, 2023
@stefaniebutland
Copy link
Member Author

stefaniebutland commented Jul 12, 2023

python with Quarto.

@stefaniebutland
Copy link
Member Author

  • Define & explain how to differentiate what goes in /examples /external /tutorials folders

@stefaniebutland
Copy link
Member Author

stefaniebutland commented Jul 14, 2023

Documenting how to add a chapter or notebook

Got a little comfortable working in the Hub.

Figured out some first-principles: how to use the 2i2c Openscapes JupyterHub to clone Cookbook to my own "local" instead of inside shared folder, used guidance from Posit's Tutorial: Hello, Quarto with Jupyter and their hello.ipynb.

  • created branch stef-learn
  • uploaded hello.ipynb to external
  • tested quarto render: output created .../site/external/hello.html but didn't look for the file
  • tested quarto preview: clicked preview https URL and Cookbook opened
  • edited _quarto.yml to have my hello.ipynb appear in nav bar under tutorials
  • preview in browser automatically updated and hello appeared in nav bar
  • discarded my changes and deleted my stef-learn branch (all in Hub)

Next steps

@stefaniebutland
Copy link
Member Author

stefaniebutland commented Aug 4, 2023

Issues have been opened in the Cookbook repo, in the NASA-Openscapes org: https://github.com/NASA-Openscapes/earthdata-cloud-cookbook/issues. Tracking in new project Cookbook Contributing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Backlog Todos
Development

No branches or pull requests

1 participant