Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Look into performance issues, especially around large vocabulary pages #496

Open
wickr opened this issue Sep 5, 2018 · 1 comment
Open

Comments

@wickr
Copy link
Member

wickr commented Sep 5, 2018

Look again at why exactly large pages are taking so long to render. One example had the /ns/creator main page taking 24 seconds.

Local profiling could help pinpoint problems. Check out https://github.com/MiniProfiler/rack-mini-profiler gem

@straleyb
Copy link
Contributor

We could do one of two things:

  1. Use Pagination or Sidekiq (with possible a separate worker allocation on the server) to process rebuilding the cache after a review occurs.

The main fix would be to rebuild the cache on review. This way, you dont have to rebuild the cache when you go to the vocabulary page. Instead, it would do it automagically.

If we did pagination, we need to support both a page with ALL the terms as well as the paginated list of terms. This wouldnt require the use of workers but would require a bit of an overhaul for the vocabulary show page with how it lists out terms, and switching between the two.

Pagination can be done with Kaminari https://github.com/kaminari/kaminari or with jquery datatables.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants