Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Share Tab form is broken. #3074

Open
straleyb opened this issue Mar 7, 2024 · 1 comment
Open

Share Tab form is broken. #3074

straleyb opened this issue Mar 7, 2024 · 1 comment
Assignees

Comments

@straleyb
Copy link
Contributor

straleyb commented Mar 7, 2024

Descriptive summary

It looks like the Share tab is broken. A user cannot add either a group nor a user to the list of shared with groups/users. A user also cannot delete a shared with user.

Expected behavior

Shared with form works.

@lamtu1 lamtu1 self-assigned this May 29, 2024
@lamtu1
Copy link
Contributor

lamtu1 commented May 31, 2024

@straleyb or @CGillen As I tested more, when it comes to Collection Sharing things are working, and when user or group are added with Manager, depositor, viewer, it doesn't show a preview that you added but if you hit the Save button and once the page refresh, it does display and store value in there.

For the Work Sharing, value does appear when click add, but once it is save, it doesn't display for some group or user due to this code I found on hyrax:

    # Fixed set of users & groups to exclude from "editable" section of display
    def exclude_from_display
      [::Ability.public_group_name, ::Ability.registered_group_name, ::Ability.admin_group_name, @depositor]
    end

I was wondering do we want to display and override this anyway in the work? (Because the data does save in form for work) and do we want to display a preview what being added into the collection knowing what has being add in?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress
Development

No branches or pull requests

2 participants