Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Uncertainty partitioning method with support for multiple realizations and downscaling method #1497

Closed
2 tasks done
huard opened this issue Oct 11, 2023 · 0 comments · Fixed by #1529
Closed
2 tasks done

Uncertainty partitioning method with support for multiple realizations and downscaling method #1497

huard opened this issue Oct 11, 2023 · 0 comments · Fixed by #1529
Labels
enhancement New feature or request

Comments

@huard
Copy link
Collaborator

huard commented Oct 11, 2023

Addressing a Problem?

Add uncertainty partitioning method that can support multiple realizations of the same model, and different downscaling method, which would let us analyse differences across ensemble products.

Potential Solution

https://www.nature.com/articles/s41612-023-00486-0

Additional context

No response

Contribution

  • I would be willing/able to open a Pull Request to contribute this feature.

Code of Conduct

  • I agree to follow this project's Code of Conduct
@huard huard added the enhancement New feature or request label Oct 11, 2023
@huard huard mentioned this issue Nov 16, 2023
Merged
11 tasks
juliettelavoie added a commit that referenced this issue Dec 14, 2023
@juliettelavoie
Add Lafferty and Sriver partition (#1529)
6529649 
<!--Please ensure the PR fulfills the following requirements! -->
<!-- If this is your first PR, make sure to add your details to the
AUTHORS.rst! -->
### Pull Request Checklist:
- [x] This PR addresses an already opened issue (for bug fixes /
features)
    - This PR fixes #1497 
- [x] Tests for the changes have been added (for bug fixes / features)
- [x] (If applicable) Documentation has been added / updated (for bug
fixes / features)
- [x] CHANGES.rst has been updated (with summary of main changes)
- [x] Link to issue (:issue:`number`) and pull request (:pull:`number`)
has been added

### What kind of change does this PR introduce?

*  Add partition algo from Lafferty and Sriver (2023)

### Does this PR introduce a breaking change?
depends (see options below)

### Other information:
TODO list in this PR:

- [x] Add weights
- [x] add tests
- [x] Maybe add `num` to `hawkins_sutton` ?
- [x] Clean up based on changes outside of this PR (eg. remove functions
that are now elsewhere)

TODO list outside of this PR:

- [ ] Add a more general `graph_fraction_of_total_variance` to figanos
(in progress by Juliette,
Ouranosinc/figanos#134)
- [ ] Add a function in xscen to prepare the data from a catalog.
(Ouranosinc/xscen#289)

In this function, I could rename the dimension to fit what the partition
vocabulary (`model`, `scenario`, `downscaling`) OR we could change the
partition vocab to the catalog/xscen vocab (`source`, `experiment`,
`bias_adjust_project`). Option 2 is my personal preference, but that
would be a breaking change for `hawkins_sutton`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add Lafferty and Sriver partition Ouranosinc/xclim
1 participant
@huard