Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate YAML using schema #1523

Closed
1 of 2 tasks
huard opened this issue Nov 14, 2023 · 1 comment · Fixed by #1560
Closed
1 of 2 tasks

Validate YAML using schema #1523

huard opened this issue Nov 14, 2023 · 1 comment · Fixed by #1560
Labels
bug Something isn't working enhancement New feature or request
Milestone
v0.48.0

Comments

@huard
Copy link
Collaborator

huard commented Nov 14, 2023

Addressing a Problem?

Help identify errors in YAML indicator definition by validating config against schema.

Potential Solution

No response

Additional context

No response

Contribution

  • I would be willing/able to open a Pull Request to contribute this feature.

Code of Conduct

  • I agree to follow this project's Code of Conduct
@huard huard added the enhancement New feature or request label Nov 14, 2023
@Zeitsperre Zeitsperre added the bug Something isn't working label Nov 14, 2023
@Zeitsperre
Copy link
Collaborator

This is also a recommendation made in LFD121.

@huard huard mentioned this issue Dec 14, 2023
Merged
5 tasks
@huard huard added this to the v0.48.0 milestone Dec 14, 2023
huard added a commit that referenced this issue Dec 15, 2023
@huard
Validate YAML file using schema before constructing module. (#1560)
03a717d 
<!--Please ensure the PR fulfills the following requirements! -->
<!-- If this is your first PR, make sure to add your details to the
AUTHORS.rst! -->
### Pull Request Checklist:
- [x] This PR addresses an already opened issue (for bug fixes /
features)
    - This PR fixes #1523
- [ ] Tests for the changes have been added (for bug fixes / features)
- [ ] (If applicable) Documentation has been added / updated (for bug
fixes / features)
- [x] CHANGES.rst has been updated (with summary of main changes)
- [ ] Link to issue (:issue:`number`) and pull request (:pull:`number`)
has been added

### What kind of change does this PR introduce?

* Use Yamale to validate schema before constructing module. Good news,
no error found in the test suite.

### Does this PR introduce a breaking change?


### Other information:

There was an issue raised by @tlogan2000 about indicators accepting
wrong arguments without failing. Could you post an offending example ?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
v0.48.0
Development

Successfully merging a pull request may close this issue.

Validate YAML file using schema before constructing module. Ouranosinc/xclim
2 participants
@huard @Zeitsperre