Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Naming of hydroclimatic variables #1912

Open
1 task done
coxipi opened this issue Sep 10, 2024 · 0 comments
Open
1 task done

Naming of hydroclimatic variables #1912

coxipi opened this issue Sep 10, 2024 · 0 comments
Assignees
Labels
help wanted Extra attention is needed
Milestone

Comments

@coxipi
Copy link
Contributor

coxipi commented Sep 10, 2024

Generic Issue

This is a discussion from #1832, see the PR discussion for more details.

  1. Discharge is both a variable type defined in units.py (like "precipitation" & "temperature"), but also a variable name in variables.yml (like pr & tas). I think it should be one or the other
  2. functions in hydrology should use something like discharge or streamflow instead of q, i.e. we should use a variable name defined in variables.yml.
  3. discharge and streamflow in variables.yml define the same quantity. Partners at hydro prefer streamflow, so we could use something similar to streamflow for the name of the variable, and keep discharge for the variable type.

Suggestions for streamflow are for instance Q, but I fear that this might be confused with quantiles. Following something like prsn, we could use stfl?

Code of Conduct

  • I agree to follow this project's Code of Conduct
@Zeitsperre Zeitsperre added the help wanted Extra attention is needed label Oct 8, 2024
@Zeitsperre Zeitsperre added this to the v0.55.0 milestone Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants