Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken PDF doc generation #341

Open
1 task done
aulemahal opened this issue Feb 12, 2024 · 2 comments
Open
1 task done

Broken PDF doc generation #341

aulemahal opened this issue Feb 12, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@aulemahal
Copy link
Collaborator

Setup Information

  • xscen version: main
  • Python version: 3.11
  • Operating System: Linux

Description

The pdf build fails : https://readthedocs.org/projects/xscen/builds/23376517/

Steps To Reproduce

cd xscen/docs/
python -m sphinx -T -b latex -d _build/doctrees -D language=en . _build/pdf
cd _build/pdf
latexmk -r latexmkrc -pdf -f -dvi- -ps- -jobname=xscen -interaction=nonstopmode

Additional context

Something is wrong in the latex code around the point where the table in the notebook is being compiled. I have avoided the error by manually inserting a closing brace "}" after the opening of the table environment in the intermediate xscen.tex file. But, of course, the table output is completely messed up in the pdf.

I suggest we drop the pdf compilation. I feel this issue is not worth anymore of our time. I have done that in #340, but we could decide the fix is not temporary.

Contribution

  • I would be willing/able to open a Pull Request to address this bug.
@aulemahal aulemahal added the bug Something isn't working label Feb 12, 2024
@RondeauG
Copy link
Collaborator

Agreed. I'm not sure that anyone looks at the PDF...

@juliettelavoie
Copy link
Contributor

i'm ok with dropping the pdf compilation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants