RegisterJavascriptObject works only on first page loaded

[sakya]

I tried to use RegisterJavascriptObject in the browser LoadEnd event and I'm seeing a strange behaviour

        private void OnBrowserLoadEnd(object sender, LoadEndEventArgs e)
        {
            Console.WriteLine("OnBrowserLoadEnd");
            if (!browser.RegisterJavascriptObject(new BindingTestClass(), "bindingTest", AsyncCallNativeMethod))
            {
                Console.WriteLine("Failed to Register Javascript Object");
            }
        }

I modified RegisterJavascriptObject to return the boolean value from _objectRegistry.Register.
The strange thing is:

• When the browser loads google the object is registerer and in the console I can access the object
• If I navigate to another page (by clicking a link or writing the address) I get the error "Failed to Register Javascript Object" because the object is registered but in the console I get "Uncaught ReferenceError: bindingTest is not defined" when I try to access the object

The code that return false is this

            if (_registeredObjects.ContainsKey(name))
            {
                return false;
            }

This should mean that the object is registered. Why I cannot access it?

[sakya]

The same happens with clean code using the menu item "Bind Javascript Object".
It works on the first loaded page but if you navigate and retry you get the error in the console

Uncaught ReferenceError: dotNetObject is not defined", source: about:blank (1)

[AndreBooysen]

I was struggling with the same issue today, The _objectRegistry.SetBrowser(browser); method that sends the registration messages for all the registered objects is only called in the OnBrowserCreated event inside the CommonBrowserAdapter class. I think it needs to be called every time a new page is loading

[AndreBooysen]

Should have opened your PR first :). I did almost the exact same fix on my side, however in the HandleLoadStart method instead of HandleLoadEnd.

[sakya]

@AndreBooysen you're right! It's better to call it in the load start event.