-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve tap #59
Comments
Yes it would be great! Would you consider waiting for #60 to be merged or base your work on it? Thanks alot! :) |
I can wait for #60 to be merged of course. However in my PR I reworked completely how the package is working. I decided to make a custom paint for each polyline instead of the layer and to implement on override on their hitTest with a touchable path. This prevent having to track where on the map the polyline is tapped and also it prevent from having to bother on how to pass the tap on the map below the polylines. |
Hey @thomascoumau, did you try to implement these changes into the package? |
Hello, I have already made a PR on this repo to improve passing the tap to the map and I have been working on improving the polyline tap for some month. I have made a PR on flutterMap here, however the maintainer prefer to let this responsibility to this pluggin. I can rework my PR on FlutterMap repo a little to reopen it on this pluggin if you would like to.
The text was updated successfully, but these errors were encountered: