Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transmission identifier should not be equal to Message-ID #436

Open
artjomsk opened this issue Nov 12, 2019 · 8 comments
Open

Transmission identifier should not be equal to Message-ID #436

artjomsk opened this issue Nov 12, 2019 · 8 comments
Labels
Issue Issue which are under review, can be bug Under review Issues currently being reviewed
Milestone

Comments

@artjomsk
Copy link

artjomsk commented Nov 12, 2019

Hello!

As far as I understand Message-ID should be unique for payload, but TransmissionID should identify a specific transmission / transmission attempt.

However, in Oxalis messageID is generated each time even for same payload. OK, we can create own MessageIdGenerator implementation. But in that case TransmissionID will be same for same payload, because in As2MessageSender:

transmissionIdentifier = TransmissionIdentifier.fromHeader(messageId);

and all the method above does is removing "<" and ">".

Is it a bug? And what is correct way to have own MessageID (probably not unique) and unique TransmissionID?

P.S. Related to #294

@klakegg
Copy link
Contributor

klakegg commented Nov 12, 2019

Where in RFC 4130 is this specificed?

@artjomsk
Copy link
Author

I've found the idea here - #133 (comment)

and for me it sounds logical. Why we need both MessageId and TransmissionId if they are almost same and always unique?

OK, from RFC 4130 section "5.5 HTTP Error Recovery":

If the HTTP client fails to read the HTTP server response data, the
POST operation with identical content, including same Message-ID,
SHOULD be repeated, if the condition is transient.
The Message-ID on a POST operation can be reused if and only if all
of the content (including the original Date) is identical.
/--/
Servers SHOULD be prepared to receive a POST with a repeated
Message-ID. The MIME reply body previously sent SHOULD be resent,
including the MDN and other MIME parts.

@klakegg
Copy link
Contributor

klakegg commented Nov 13, 2019

The section from RFC 4130 is related to Message-ID during retry. How about TransmissionID?

@artjomsk
Copy link
Author

TransmissionID is not specified in RFC 4130, it looks like implementation details of Oxalis. And you should know its meaning. Please, give short description why TransmissionID is needed if it's hardcoded to be almost same to MessageID and how it correlates the fact MessageID can be repeated (retry case)

@phax
Copy link

phax commented Feb 19, 2020

See chapter 3.2 "Reception Awareness features and Duplicate Detection" of the OASIS AS4 profile

@SuperJuell
Copy link

This issue is closed due to age and lack of activity.

@open-gdsn
Copy link

open-gdsn commented Feb 4, 2021

Closing due to lack of activity from the former code maintainers does not feel right. If in a retransmission, the messageID changes that is wrong (did not test this) but in the http://docs.oasis-open.org/ebxml-msg/ebms/v3.0/profiles/AS4-profile/v1.0/AS4-profile-v1.0.pdf

This is stated:

If doing so, theeb:MessageInfo/eb:MessageId element of the resent mes-sage and of the original User message MUST be same.

@SuperJuell
Copy link

Hi, I'm sorry for closing this issue. We will make sure this is analysed further.

@SuperJuell SuperJuell reopened this Feb 5, 2021
@aaron-kumar aaron-kumar added Pri/L Low priority Under review Issues currently being reviewed labels Jun 3, 2021
@aaron-kumar aaron-kumar added the Issue Issue which are under review, can be bug label Dec 6, 2021
@aaron-kumar aaron-kumar added this to the 5.x.x milestone Dec 6, 2021
@aaron-kumar aaron-kumar moved this to Open Issues- Review Required in Oxalis Public Roadmap Dec 6, 2021
@aaron-kumar aaron-kumar removed Under review Issues currently being reviewed Pri/L Low priority labels Jul 29, 2022
@aaron-kumar aaron-kumar added the Under review Issues currently being reviewed label Oct 22, 2022
@aaron-kumar aaron-kumar modified the milestones: 5.x.x, 6.x.x Jan 16, 2023
@aaron-kumar aaron-kumar moved this from Open Issues- Review Required to Q1 2023 –Jan-March in Oxalis Public Roadmap Jan 16, 2023
@aaron-kumar aaron-kumar moved this from Q2 2023 – April-June to Q4 2023 – October-December in Oxalis Public Roadmap Sep 25, 2023
@aaron-kumar aaron-kumar moved this from Q4 2023 – October-December to Future in Oxalis Public Roadmap Dec 9, 2023
@aaron-kumar aaron-kumar modified the milestones: 6.x.x, 7.x.x Dec 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue Issue which are under review, can be bug Under review Issues currently being reviewed
Projects
Status: Future
Development

No branches or pull requests

6 participants