Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quickly moving queue items breaks queue display #838

Open
4 tasks done
starchyunderscore opened this issue Jul 23, 2024 · 4 comments
Open
4 tasks done

Quickly moving queue items breaks queue display #838

starchyunderscore opened this issue Jul 23, 2024 · 4 comments
Assignees
Labels
bug Something isn't working playback Related to music playback

Comments

@starchyunderscore
Copy link

Describe the Bug/Crash

  1. have several songs in queue
  2. move one quickly above and then below currently playing song
  3. observe that playing indicator may now be on another song or several

Screenshot_20240723-103713

https://youtu.be/o7xAu_xXPk4

Describe the intended behavior

playing indicator should stay on only currently playing song regardless of movement of other songs.

What android version do you use?

Android 13

What device model do you use?

moto g stylus 5g (2022)

auxio 3.5.2

Provide a sample file

n/a

Bug report

n/a

Duplicates

@starchyunderscore starchyunderscore added the bug Something isn't working label Jul 23, 2024
@starchyunderscore
Copy link
Author

relatedly, songs may still be marked as already played (slightly greyed-out) may make seprate issue for this

Screenshot_20240723-110002

note song "21 guns"

@starchyunderscore
Copy link
Author

also also: by "now playing indicator" i mean the purple text & bars animation, the indicator at the top of the screen is correct.

@starchyunderscore
Copy link
Author

starchyunderscore commented Jul 23, 2024

seems it may be able to also duplicate song entries in queue... not sure if functional or just visual

https://youtube.com/shorts/cTbHfjsK6Bc?feature=share

(video shows duplication with currently playing song, can happen with not playing one as well)

seems like these effects only happen in cases where other songs do not dynamically move when rearranging queue... another symptom?

@starchyunderscore starchyunderscore changed the title [bug] moving songs in queue sometimes causes playing indicator to be on wrong song [bug] moving songs in queue sometimes causes weird visual behavior Jul 23, 2024
@OxygenCobalt
Copy link
Owner

Aware of this. The issue is that ExoPlayer doesn't correctly update the shuffle order when items are moved, so I have to hack around it in really messy ways instead. The current way works fine if you do simple slow moves, but breaks if you are too fast. I need to make a patch to fix this, which is risky since ExoPlayer's internal queueing is quite complicated and easy to break.

@OxygenCobalt OxygenCobalt changed the title [bug] moving songs in queue sometimes causes weird visual behavior Quickly moving queue items breaks queue display Jul 25, 2024
@OxygenCobalt OxygenCobalt added the playback Related to music playback label Jul 25, 2024
@OxygenCobalt OxygenCobalt moved this to v4.X.0 in Auxio Roadmap Aug 26, 2024
@OxygenCobalt OxygenCobalt moved this from v4.X.0 to Big ExoPlayer Patch Update in Auxio Roadmap Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working playback Related to music playback
Projects
Status: Playback Refinement Update
Development

No branches or pull requests

2 participants