Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Precomputed values are slightly different from the ones in the original project! #2

Open
OzgurCerlet opened this issue Jul 11, 2018 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@OzgurCerlet
Copy link
Owner

OzgurCerlet commented Jul 11, 2018

Precomputed values in the textures are slightly different from the ones in the original project. It was really hard to track the values computed by the shaders, but if my readings from RenderDoc are correct, glsl and hlsl versions of sqrt() give slightly different results. I do not know if this small discrepancy accounts for
the differences or there is an extra subtle bug somewhere. For usual view and sun positions there is no visible difference between the original demo and this one, but it is there.

@OzgurCerlet OzgurCerlet added the bug Something isn't working label Jul 11, 2018
@OzgurCerlet OzgurCerlet self-assigned this Jul 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant