payment.xml validation

[c-walter]

Hey, please check

magento-2/etc/payment.xml

Line 48 in e68394b

</method>v

for latest versions. There is a "v" in the xml which is there by mistake.

[Morgy93]

Fixed via #572

Please release ASAP 🙏

[JasiukiewiczM]

Fixed 3 weeks ago and still waiting for release? Why is that?

[janteuber]

We won't do a separate release for such a small change. This adjustment will be included in the next release.

[Morgy93]

We won't do a separate release for such a small change. This adjustment will be included in the next release.

Could you consider releasing a patch version? That’s exactly what they’re meant for.
A 3.13.2 release would be ideal.
Since 3.13.1 is currently broken, it would greatly benefit all users to have a fixed version available as soon as possible.

[janteuber]

Hi everyone,

I've fixed the issue from GitHub and released a new plugin version. Check it out here: v3.13.2 Release.

Thanks for your patience!

Best,
Jan

[Morgy93]

Hi everyone,

I've fixed the issue from GitHub and released a new plugin version. Check it out here: v3.13.2 Release.

Thanks for your patience!

Best, Jan

Thank you for your efforts!

I now understand why you hesitated to create a patch release—it seems the project doesn’t strictly adhere to semantic versioning (semver). Please don’t take this as criticism; it’s just feedback that I believe is important for users of this module to be aware of.

In version 3.13.2, new features were introduced compared to 3.13.1, which technically goes against the guidelines of semver. This isn’t a problem in itself, but it’s something users should know beforehand when including this module.

Just as a quick reminder, under semantic versioning:

Given a version number MAJOR.MINOR.PATCH, increment the:

1. MAJOR version when you make incompatible API changes
2. MINOR version when you add functionality in a backward compatible manner
3. PATCH version when you make backward compatible bug fixes

https://semver.org/

Thanks again for your work!