Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

read20 should print author information #66

Open
ams opened this issue Nov 22, 2022 · 4 comments
Open

read20 should print author information #66

ams opened this issue Nov 22, 2022 · 4 comments

Comments

@ams
Copy link

ams commented Nov 22, 2022

TOPS-20 tapes store author information, read20 should print it.

For dump.h add:

#define WdoffAuthor      WdoffFDB+030   /* Author offset */

Then in doFileHeader:

    getstring(block, authorname, WdoffAuthor, sizeof(authorname), STRING);

and print it when in verbose mode:

printf("%5d%9d %2d %o %s %s %s", offline ? apgcount : pgcount,
                   numbytes, bytesize, tprot, timeptr, topsname, authorname);
@Rhialto
Copy link
Member

Rhialto commented Nov 22, 2022

Sounds like a good idea!
When I try to compile read20, I notice lots of compiler warnings. I'll clean it up first, and then get to your change.

@ams
Copy link
Author

ams commented Nov 22, 2022

Hm, is there any reason to clean up? Wouldn't it be better to sync this version of read20 with the one in https://github.com/brouhaha/tapeutils ?

@Rhialto
Copy link
Member

Rhialto commented Nov 22, 2022

I wasn't aware of that version It seems the version have diverged. Maybe it is smarter to ask brouhaha to incorporate any improvements that KLH made to this version.

@larsbrinkhoff
Copy link
Member

@brouhaha has mostly left the maintenance of https://github.com/brouhaha/tapeutils/ to me. Yes, I agree that merging all diverging versions to the brouhaha upstream would be good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants