Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extension of data format to allow for lists of simulationConditions and timepoints #16

Open
dweindl opened this issue Dec 11, 2018 · 3 comments · May be fixed by #581
Open

Extension of data format to allow for lists of simulationConditions and timepoints #16

dweindl opened this issue Dec 11, 2018 · 3 comments · May be fixed by #581
Labels
question Further information is requested specification change

Comments

@dweindl
Copy link
Member

dweindl commented Dec 11, 2018

To be discussed at a later point

@dweindl dweindl added the question Further information is requested label Dec 11, 2018
@yannikschaelte yannikschaelte added this to the file format version 2 milestone Mar 31, 2020
@paulstapor
Copy link
Contributor

Sounds to me like something that could (theoretically) be handled by an event in some way... We have not really talked about how to implement events in PEtab beyond waht's supported in SBML: Another such point would be event observables...

@dweindl
Copy link
Member Author

dweindl commented Jul 29, 2020

could (theoretically) be handled by an event in some way

Definitely.

I would find it nice, though, if the model would focus on the biology, and any weird experimental setups used to generate training data could be kept out of there. The model would have include the superset of all events, which could get messy if you have a number of different setups. (Alternatively you could build a different model for each of those, but that's no fun either).

Also it would be a nice feature if we want to support non-SBML models in the future, that don't come with anything like events (#436).

@dweindl
Copy link
Member Author

dweindl commented May 23, 2024

See also #581

@dweindl dweindl linked a pull request May 23, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested specification change
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants