Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flatten_timepoint_specific_output_overrides does not update visualization table #313

Open
dweindl opened this issue Oct 17, 2024 · 2 comments

Comments

@dweindl
Copy link
Member

dweindl commented Oct 17, 2024

flatten_timepoint_specific_output_overrides does not update the visualization table. The resulting problem does not pass validation. Can be observed, for example, with https://github.com/Benchmarking-Initiative/Benchmark-Models-PEtab/tree/v2024.10.15/Benchmark-Models/Isensee_JCB2018.

@m-philipps
Copy link
Collaborator

A flattened visualization table is probably not useful so the table could be removed for the flattened problem, as long as the visualization table stays optional.

@dweindl
Copy link
Member Author

dweindl commented Oct 17, 2024

Agreed, unsetting problem.visualization_df would suffice. However, this should only happen if the changes really make the visualization table invalid.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants