Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove need for merged=True from user interface #849

Open
nicolasaunai opened this issue May 29, 2024 · 2 comments
Open

remove need for merged=True from user interface #849

nicolasaunai opened this issue May 29, 2024 · 2 comments
Assignees
Milestone

Comments

@nicolasaunai
Copy link
Member

Users should not have to worry about having to set merge=True or not when getting data with run.GetXXX().
Merged=True is currently there so that users may get an interpolator to get data wherever they want from the finest data in the hierarchy. They should be able to do that from a PatchHierarchy already. There's the __call__() in PatchHierarchy but I think it's kinda broken as it's (and was intended as is) not using an interpolator, but that probably is silly...

@PhilipDeegan
Copy link
Member

is this still the case since recent PatchHierarchy updates?

@nicolasaunai
Copy link
Member Author

yes, it's still there and I think it should not. The idea is that one should be able to do a slice in a PatchHierarchy representing a ScalarField or a VectorField anywhere and that should do the interpolation as needed without the need for the user to a priori decide whether to put merged=True or not. There should only be PatchHierarchies and that's it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Do me  👋
Development

No branches or pull requests

2 participants