Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run ABIN through Valgrind #112

Open
danielhollas opened this issue Apr 18, 2022 · 1 comment
Open

Run ABIN through Valgrind #112

danielhollas opened this issue Apr 18, 2022 · 1 comment
Assignees
@danielhollas
Labels
testing Any changes to Github Actions or testing scripts.

Comments

@danielhollas
Copy link
Contributor

danielhollas commented Apr 18, 2022 •
edited
Loading

GCC also offers some sanitization options that we might want to enable in the CI.

https://gcc.gnu.org/onlinedocs/gcc/Instrumentation-Options.html
@danielhollas danielhollas added the testing Any changes to Github Actions or testing scripts. label Apr 18, 2022
@danielhollas danielhollas self-assigned this Apr 18, 2022
@danielhollas
Copy link
Contributor Author

I've run test suite locally with

FFLAGS = -O0 -fopenmp --coverage -fsanitize=address,undefined -fcheck=all -fno-inline -fimplicit-none -Wall -Wno-integer-division -Wno-maybe-uninitialized
LDFLAGS = --coverage -fsanitize=address,leak,undefined

I found one issue that is fixed in #160. We should consider having an extra workflow with these settings enabled but without coverage, because fcheck=all apparently messes up the code coverage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danielhollas danielhollas

Labels
testing Any changes to Github Actions or testing scripts.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@danielhollas