Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No Scrutinizer Runs Today #3788

Closed
oleibman opened this issue Nov 10, 2023 · 4 comments
Closed

No Scrutinizer Runs Today #3788

oleibman opened this issue Nov 10, 2023 · 4 comments

Comments

@oleibman
Copy link
Collaborator

@PowerKiKi @MarkBaker No PRs submitted today have run a Scrutinizer step. Are you aware of any changes that would prevent it?

And, as long as I have your attention, what do you think of PR 3778 (make Php 8.3 not experimental)? I think we're only a couple of weeks away from its official release. Can we merge 3778 after that happens (the nightly run has had no failures/errors for several weeks now), mark Php 8.3 as required (I don't know how to do that), and then make an official release?

@PowerKiKi
Copy link
Member

I merged #3778, where Srcutinizer ran successfully. I suppose something went temporarily wrong on their side ...

@PowerKiKi
Copy link
Member

PowerKiKi commented Nov 13, 2023

Btw, this remind me that I never released the native typing I added in #3718. I added a lot of native typing, but not all. Especially I did not touch classes/interfaces that are expected to be inherited, eg IValueBinder, because this would be a major change. But I think we should do that at some point...

My opinion is to add typing to the remaining classes/interfaces and release all of this as a 2.0.0. @MarkBaker, @oleibman would that be OK with you ?

@oleibman
Copy link
Collaborator Author

That plan is okay by me.

@PowerKiKi
Copy link
Member

See #3793

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants