Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal fixes #523

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Proposal fixes #523

wants to merge 9 commits into from

Conversation

Duddino
Copy link
Member

@Duddino Duddino commented Jan 13, 2025

Abstract

This should fix the proposal creation flow
Fixes #508

A new button has been added. It allows the user to delete a local proposal. This means losing access to the collateral.
A confirmation modal has been added
image
image

Testing

  • Create a proposal
  • Assert that it correctly displays the status
  • Test that it finalizes automatically and it's removed once finalied

@Duddino Duddino added the Bug This is either a bugfix (PR) or a bug (issue). label Jan 13, 2025
@Duddino Duddino self-assigned this Jan 13, 2025
Copy link

netlify bot commented Jan 13, 2025

Deploy Preview for cheery-moxie-4f1121 ready!

Name Link
🔨 Latest commit ed706f0
🔍 Latest deploy log https://app.netlify.com/sites/cheery-moxie-4f1121/deploys/67879135d650ce00088c0790
😎 Deploy Preview https://deploy-preview-523--cheery-moxie-4f1121.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Duddino Duddino added the Enhancement New feature or request label Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug This is either a bugfix (PR) or a bug (issue). Enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Proposal finalization errors out despite submitting fine
2 participants