Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve integration test for checking for DNS records #2

Open
ebekker opened this issue May 11, 2018 · 0 comments
Open

Improve integration test for checking for DNS records #2

ebekker opened this issue May 11, 2018 · 0 comments

Comments

@ebekker
Copy link
Member

ebekker commented May 11, 2018

The current set of integration tests for Orders and dns-01 Challenges can take a potentially long time to validate either the existence or lack thereof a test record in the DNS system.

The code for this DNS testing does a normal DNS look up which goes through local system's DNS resolver and can be impacted by various caching points but ultimately it can have a wide range of wait times.

For example in the Windows tests the wait for deleted records takes as much as 4.5 minutes (search for _IsDeleted_) and over 1 minute for testing for the existence of newly created records (search for _Exists_).

However in the same set of tests on Linux the same corresponding tests take can take as little as 10 seconds.

In order to provider more consistent and predictable behavior and speed up the execution of the tests in general, it would be useful to improve DNS lookups to resolve the DNS provider specific to the test record domain and then query the provider's DNS servers directly, i.e. resolve the DNS NS records for the target root domain.

ebekker pushed a commit that referenced this issue Feb 17, 2019
ebekker pushed a commit that referenced this issue Dec 17, 2019
Merge master to win-acme branch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant