Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some collection resource does not include URL keys: surveys, countries... #21

Open
joeflack4 opened this issue Jul 24, 2018 · 0 comments
Assignees
Labels
P3 Priority: 3/5 (1=High, 5=Low) ux issue User experience issue.

Comments

@joeflack4
Copy link
Contributor

Description

Survey collection resource does not include URL keys for instances shown in results.

Affected resources
  • surveys
  • countries
  • others?

In contrast, an example of a resource where this appears to have been implemented correctly is: http://api.pma2020.org/v1/indicators

Expected behavior

http://api.pma2020.org/v1/surveys

{
  "metadata": {
    ...
  }, 
  "resultSize": 48, 
  "results": [
    {
      "country.id": "GH", 
      "country.label": "Ghana", 
      "country.order": 4, 
      "country.region": "Africa", 
      "country.subregion": "Western Africa", 
      "end_date": "2013-10-01", 
      "id": "PMA2013_GHR1", 
      "order": 101, 
      "pma_code": "GHR1", 
      "round": 1, 
      "start_date": "2013-09-01", 
      "type": "PMA2020", 
      "year": 2013
      "url": "http://api.pma2020.org/v1/surveys/PMA2013_GHR1"
    }, 
    ...

Actual behavior

http://api.pma2020.org/v1/surveys

{
  "metadata": {
    ...
  }, 
  "resultSize": 48, 
  "results": [
    {
      "country.id": "GH", 
      "country.label": "Ghana", 
      "country.order": 4, 
      "country.region": "Africa", 
      "country.subregion": "Western Africa", 
      "end_date": "2013-10-01", 
      "id": "PMA2013_GHR1", 
      "order": 101, 
      "pma_code": "GHR1", 
      "round": 1, 
      "start_date": "2013-09-01", 
      "type": "PMA2020", 
      "year": 2013
    }, 
    ...
@joeflack4 joeflack4 added the ux issue User experience issue. label Jul 24, 2018
@joeflack4 joeflack4 added the P3 Priority: 3/5 (1=High, 5=Low) label Aug 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P3 Priority: 3/5 (1=High, 5=Low) ux issue User experience issue.
Projects
None yet
Development

No branches or pull requests

2 participants