Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAF thresholds above 0.01 won't work #132

Closed
bfclarke opened this issue Aug 28, 2024 · 0 comments · Fixed by #138
Closed

MAF thresholds above 0.01 won't work #132

bfclarke opened this issue Aug 28, 2024 · 0 comments · Fixed by #138
Assignees
Labels
bug Something isn't working

Comments

@bfclarke
Copy link
Contributor

bfclarke commented Aug 28, 2024

Setting a MAF threshold above 0.01 for *_data_thresholds in deeprvat_input_config.yaml won't work because of the below lines in base_configurations.yaml, which don't get updated when the full config is generated.

training_data:
    dataset_config:
        min_common_af:
            MAF: 0.01

association_testing_data:
    dataset_config:
        min_common_af:
            MAF: 0.01
@bfclarke bfclarke added the bug Something isn't working label Aug 28, 2024
@meyerkm meyerkm linked a pull request Sep 24, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants