-
-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tax function estimation #96
Comments
Some key questions:
|
I've started looking into the estimation of the tax functions. Some questions I have:
|
Re the method of numerical optimization, I'm seeing significant differences across the numerical algorithm used to minimize the nonlinear least squares function. Here are the tax functions for each age estimated using a few different algorithms: DEP functional form:L-BFGS-B methodCPS dataPUF dataSLSQP methodCPS dataPUF dataNelder-Mead methodCPS dataPUF dataGS functional form:L-BFGS-B methodCPS dataPUF dataSLSQPCPS dataPUF dataNelder-MeadCPS dataPUF dataSummary:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Beginning with PR #73, which updated the default calibration of OG-USA, we have observed some odd results related to the estimated tax functions. This issue will document what we've noticed in the hopes that we can address any issues with the tax function estimation routines or with the microsimulation model used to calibrate OG-USA (or both).
Things that haven't seemed quite right:
mono
andmono2D
functional form for the tax functions, there were failures in the estimation (e.g., no minimum found) (again, using Tax-Calculator 3.4.1)ogusa_default_parameters.json
, the warnings and performance reductions pretty much disappear.The text was updated successfully, but these errors were encountered: