Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for disabling the Edit action on all rows of the PagerDutyPage component #124

Open
alpinweis opened this issue Jul 24, 2024 · 3 comments
Labels
enhancement New feature or request under review Issues being reviewed

Comments

@alpinweis
Copy link

Is your feature request related to a problem? Please describe.
I'd like to be able to disable the possibility for users to use the Edit action of the PagerDutyPage component and use the PagerDutyPage mostly in a read-only mode.

Describe the solution you'd like
I'd like to be able to disable the Edit action of the PagerDutyPage component from code using an option like disableEditAction, something similar to how it's done for ChangeEvents, e.g. <EntityPagerDutyCard disableChangeEvents>

Describe alternatives you've considered
N/A

pd edit action

@alpinweis alpinweis added the enhancement New feature or request label Jul 24, 2024
@t1agob
Copy link
Contributor

t1agob commented Jul 25, 2024

Hey @alpinweis!

Quick question here for additional context...if you don't have the edit button, what would you use this page for? This page is mainly intended to provide a quick way of editing mappings.

@alpinweis
Copy link
Author

@t1agob It helps find out quickly what services in our backstage instance do not have PagerDuty integration enabled yet.
Also, having the mapping PagerDuty to backstage in a nice visual format is pretty helpful.
In my org the preference is for having the integrations be done in code (helps keep track of changes), instead of by folks interactively/directly from the backstage UI

@t1agob
Copy link
Contributor

t1agob commented Jul 25, 2024

Got it! Thanks for sharing. I'll review this then.

Btw, we have a feature request in the roadmap to open a PR in the Backstage entity source when a new mapping is defined on this page. Then, you could use the UI and still enforce code-first 😉

@t1agob t1agob added the under review Issues being reviewed label Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request under review Issues being reviewed
Projects
None yet
Development

No branches or pull requests

2 participants