From bada44e1ea4d64074981c3afae14f9a2f721ae93 Mon Sep 17 00:00:00 2001 From: Andrei Soroker Date: Fri, 10 Mar 2023 16:50:59 -0800 Subject: [PATCH] Update 10-OAuth-2-PKCE.md > Base64 URL Encoded (without padding) string containing the SHA-256 digested form of the clients one-time random 128 byte verifier (also in Base64URLEncoded form without padding). "clients" is incorrect, needs to be "client's" "128 byte verifier" is incorrect - it's 128-byte *after* the verifier is base64-encoded. Actual verifier can be somewhere between 90 and 110 bytes; example code uses 93, so let's go with that. --- docs/app-integration-development/10-OAuth-2-PKCE.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/app-integration-development/10-OAuth-2-PKCE.md b/docs/app-integration-development/10-OAuth-2-PKCE.md index a3f13bd..d7c2b04 100644 --- a/docs/app-integration-development/10-OAuth-2-PKCE.md +++ b/docs/app-integration-development/10-OAuth-2-PKCE.md @@ -35,7 +35,7 @@ Required Parameters | Description `redirect_uri` | Registered with the app when OAuth 2.0 is added. PagerDuty will redirect here after a user grants or denies access to your app. `response_type` | Specifies the response type based on OAuth 2.0 flow.
Value must be set to `code`. `scope` | Specifies the scope being requested, must match what is configured on the OAuth application. -`code_challenge` | Base64 URL Encoded (without padding) string containing the SHA-256 digested form of the clients one-time random 128 byte verifier (also in Base64URLEncoded form without padding). See Javascript PKCE Example Algorithm below. +`code_challenge` | Base64 URL Encoded (without padding) string containing the SHA-256 digested form of the client's one-time random 93-byte verifier (also in Base64URLEncoded form without padding; not to exceed 128 bytes). See Javascript PKCE Example Algorithm below. `code_challenge_method` | Specifies that we are using PKCE SHA-256 Signature.
Value must be set to `S256`. The flow is initiated by sending a GET request to the Authorization Endpoint with query parameters set for `client_id`, `redirect_uri`, `scope`, `response_type=code`, as well as the PKCE extension fields (`code_challenge` and `code_challenge_method`)