Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

db build does not output anything if there is build folder and/or tsconfig.tsbuildinfo file present #64

Open
GGAlanSmithee opened this issue Mar 5, 2024 · 2 comments · May be fixed by #65

Comments

@GGAlanSmithee
Copy link

See the attached video

Explanation: In the db project of any template, if you manually delete the build folder and re-run npm run build, nothing gets outputted if the tsconfig.tsbuildinfo file is present. I guess this could be by design, since the tsconfig.buildinfo file might be some kind of a lock file, indicating that the build is up to date, but in practice, this hinder any other script that relies on that output being there, such as npm run pack from the respective templates root folder.

Suggested solution: add a clean script, such as

"scripts": {
  "clean": "rm -rf tsconfig.tsbuildinfo & rm -rf build",
  "build": "npm run clean & tsc -p tsconfig.json && tsc-alias -p tsconfig.json",
}

I can send a PR if you want me to.

20240305_130940.mp4
@SebastienGllmt
Copy link
Contributor

There is a wipe.sh script for this, but you're right we should probably expose that script as part of a clean command so it's easier to find

@GGAlanSmithee
Copy link
Author

ah ok, did not know, thanks @SebastienGllmt I will send a PR, you can accept if you want too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants