-
Notifications
You must be signed in to change notification settings - Fork 97
Update animated gif for different trigger options #107
Comments
@jmatsushita ,I have observed one point:-- There are two files in assets/media/mobile folder-
So ideally, the gif file is not played if the setup is done from any other language (may be designed so because the text strings used in gif are in english). You can verify this behavior of the app, from the latest playstore version. |
Good point we should localise the button. Could you please for now make sure there is a different gif file name for each language (just copying the latest version)? I will then change the file when it is localised. Thanks! |
Presume that further changes will need to be made after #178 is implemented. |
Committed new 7 presses default in 1e7521b |
@niccs There is probably a bit of new logic to create in order to display the new animations. Can we create new JSON objects for each trigger option (7 press, 5 press + confirmation, custom) and dynamically link to the one that needs to be displayed so we can still configure the image and text in the JSON? |
@jmatsushita , I think we can dynamically pick the images. json will just parse and store the name of image in sqliteDB, and while fetching we can change that. No need of creating new json objects. We are just using this in hardware training screen. |
As per our discussion, I am putting down three cases: Case -1) default 7 repeated press:-- The app will pick the locale specific .gif file name from mobile_xx.json file and play it. The file name is:-- panic_button_activation_360_xx.gif Case -2) 5 Presses plus confirmation:- We need the resource name. Right now, I am using-- panic_button_activation_5press_confirm_xx.gif . and will checkin the same default existing gif fille change its name. Case-3) Custom settings:-- It will take the static image panic_button_activation.png and with that a toast message is displayed |
The current one only instructs to do 4 presses before confirming.
The text was updated successfully, but these errors were encountered: