Skip to content
This repository has been archived by the owner on Mar 27, 2020. It is now read-only.

Update animated gif for different trigger options #107

Open
jmatsushita opened this issue Sep 18, 2015 · 7 comments
Open

Update animated gif for different trigger options #107

jmatsushita opened this issue Sep 18, 2015 · 7 comments
Assignees
Milestone

Comments

@jmatsushita
Copy link
Member

The current one only instructs to do 4 presses before confirming.

@jmatsushita jmatsushita added this to the v1.4.1 milestone Sep 18, 2015
@jmatsushita jmatsushita assigned niccs and jmatsushita and unassigned niccs Sep 18, 2015
@jmatsushita jmatsushita assigned niccs and unassigned jmatsushita Oct 6, 2015
@niccs niccs added in progress and removed current labels Oct 6, 2015
@niccs
Copy link
Member

niccs commented Oct 7, 2015

@jmatsushita ,I have observed one point:--

There are two files in assets/media/mobile folder-

  1. panic_button_activation_360.gif --- used only for English language and
    2)panic_button_activation.png --used for all other languages

So ideally, the gif file is not played if the setup is done from any other language (may be designed so because the text strings used in gif are in english). You can verify this behavior of the app, from the latest playstore version.
Please comment.

@niccs niccs added review and removed in progress labels Oct 7, 2015
@jmatsushita
Copy link
Member Author

Good point we should localise the button. Could you please for now make sure there is a different gif file name for each language (just copying the latest version)? I will then change the file when it is localised. Thanks!

@niccs niccs added review and removed in progress labels Oct 19, 2015
@niccs niccs assigned jmatsushita and unassigned niccs Nov 11, 2015
@jimmylogan
Copy link
Collaborator

Presume that further changes will need to be made after #178 is implemented.

@jmatsushita
Copy link
Member Author

Committed new 7 presses default in 1e7521b

@jmatsushita jmatsushita added review and removed current labels Feb 1, 2016
@jmatsushita jmatsushita changed the title Update animated gif with 5 presses Update animated gif for different trigger options Feb 1, 2016
@jmatsushita jmatsushita changed the title Update animated gif for different trigger options Update animated gif with 5 presses Feb 1, 2016
jmatsushita added a commit that referenced this issue Feb 1, 2016
@jmatsushita
Copy link
Member Author

@niccs There is probably a bit of new logic to create in order to display the new animations. Can we create new JSON objects for each trigger option (7 press, 5 press + confirmation, custom) and dynamically link to the one that needs to be displayed so we can still configure the image and text in the JSON?

@jmatsushita jmatsushita changed the title Update animated gif with 5 presses Update animated gif for different trigger options Feb 1, 2016
@niccs
Copy link
Member

niccs commented Feb 2, 2016

@jmatsushita , I think we can dynamically pick the images. json will just parse and store the name of image in sqliteDB, and while fetching we can change that. No need of creating new json objects. We are just using this in hardware training screen.

@niccs niccs added current and removed in progress labels Feb 3, 2016
@niccs niccs added in progress and removed current labels Mar 7, 2016
@niccs
Copy link
Member

niccs commented Mar 9, 2016

@jmatsushita ,

As per our discussion, I am putting down three cases:

Case -1) default 7 repeated press:-- The app will pick the locale specific .gif file name from mobile_xx.json file and play it. The file name is:-- panic_button_activation_360_xx.gif

Case -2) 5 Presses plus confirmation:- We need the resource name. Right now, I am using-- panic_button_activation_5press_confirm_xx.gif . and will checkin the same default existing gif fille change its name.

Case-3) Custom settings:-- It will take the static image panic_button_activation.png and with that a toast message is displayed
a) --" X Repeated presses and then press for confirmation within 3 seconds"--(in case confirmation is activated)
b) --" X Repeated presses "--(in case confirmation is not activated))

niccs added a commit that referenced this issue Mar 14, 2016
@niccs niccs added review and removed in progress labels Mar 14, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants