Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate Transifex #9

Open
jmatsushita opened this issue Oct 20, 2015 · 8 comments
Open

Integrate Transifex #9

jmatsushita opened this issue Oct 20, 2015 · 8 comments
Assignees
Labels

Comments

@jmatsushita
Copy link
Member

http://docs.transifex.com/live/quick-start-guide/

Look into a "do not track" alternative, as in generate .md files from the Transifex translations.

@naturalshine
Copy link
Contributor

K mentioned that the ajax loading for translation makes tracking possible. But two tiers of questions here:
(1) Where is translation currently happening on the site -- I can't find it anywhere, but maybe I'm being daft? I see the translated content in /api/{languages} -- but how does the user access this interface?
(2) I've never used Transifex before, but I'll look into it -- or would subbing the ajax translation script with more innocuous javascript be ok -- or am I missing the point completely?

Basically: how is translation currently occurring (probably answered by point 1 above) and how much needs to change to create a less vulnerable translation experience?

@jmatsushita
Copy link
Member Author

(1) It's managed here: https://www.transifex.com/otf/panic-button/ Can you create a transifex account and let me know your username and I'll give you access to the Transifex Live preview.

(2) For now let's just integrate the existing Ajax based solution. Although please note we'll probably want to keep that on the staging site on github, and only push this to master when we've reviewed the translation.

Making the translation more ethical would require to push the site as markdown which I've been discussing and creating some tooling for here but you don't need to worry about it for this task.

@naturalshine
Copy link
Contributor

Ah, ok, this clears up a lot. I made a Transifex account: cstolan

I'll plan to implement the ajax functionality after I finish the other issues, as I think this will be the most time-consuming part of the project.

@jmatsushita
Copy link
Member Author

Just added you as a maintainer. You should be able to go there: https://www.transifex.com/otf/panic-button/ and hit the "Live" button to see the current translations.

Then you can follow this documentation to do embed the "live" functionality into the site. Please do so in a transifex branch so we can merge it separately from pact.

naturalshine added a commit to naturalshine/panicbutton.io that referenced this issue Jan 21, 2016
@naturalshine
Copy link
Contributor

@jmatsushita @jimmylogan
I've integrated Transifex on my own staging site, here.
Just to make sure I did things properly before making pull request -- is this all there is to do, or is there something more complicated (ie do you want a custom-designed language picker)?
I've set up this url (https://naturalshine.github.io/panicbutton.io/) as the "staging" transifex url, but it can be changed to the panicbutton gh-pages once the pull request goes through. This will allow the translation to be reviewed before the translations are taken live in production.
Thanks!

@naturalshine
Copy link
Contributor

One quick note -- you can log into the transfiex dashboard on the staging site with this url.

@jmatsushita
Copy link
Member Author

I could create a translation branch and merge this work there, generate and push to gh-pages to have a staging site for languages.

In the meantime @jimmylogan can you look at the url from @naturalshine and think about review?

@jmatsushita jmatsushita added review and removed ready labels Jan 22, 2016
@jimmylogan
Copy link
Contributor

ok - have put a question on glip about this @jmatsushita

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants