Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need sound controller #4

Open
2 tasks
ParadoxZero opened this issue Dec 14, 2016 · 10 comments
Open
2 tasks

Need sound controller #4

ParadoxZero opened this issue Dec 14, 2016 · 10 comments

Comments

@ParadoxZero
Copy link
Owner

ParadoxZero commented Dec 14, 2016

Need a class, which will handle sound.

  • Play a BGM
  • Provide interface to play sound effects. Something like
    playSound(Sounds::EatFood);
@dev-patel2104
Copy link

@ParadoxZero is this issue still open ?

@ParadoxZero
Copy link
Owner Author

@dev-patel2104 Yes it is.

@dev-patel2104
Copy link

@ParadoxZero do you want me to create an interface and then implement a class or should i just create a class with a function in it

@ParadoxZero
Copy link
Owner Author

@dev-patel2104 From top of my mind, how I'll approach this is to create an internal interface (a class) for the playing Audio etc. Perhaps declare different Audio asset via an enum. Then the components e.g. snake will play audio related to it, while eating food, eating itself etc and BGM will be controlled by the game controller.

@dev-patel2104
Copy link

@ParadoxZero sorry to bother you but do you have any formal criteria for tests on which you will accept the pull request or that you want us to involve during testing

@ParadoxZero
Copy link
Owner Author

@dev-patel2104 This is something I made during college to learn sfml 😄 There are no formal criteria,

As long as it works that's great. I am gonna trust you on the quality of the build since you are taking time out andwriting the code. Other than that, I'll review the PR and share any recommendations I may have.

But go crazy, it's an informal project and the key is to have fun.

@stelios357
Copy link

Hey @ParadoxZero. I have been working with @dev-patel2104 on this issue since our first communication. We are a team of 10 members. Please don't assign this issue to anybody else.
Also, we have been trying to debug this issue for quite some time now, It'll be of great help if you could look into it :
Run-Time Check Failure #2 - Stack around the variable 'text' was corrupted.
image

Thankyou.

@ParadoxZero
Copy link
Owner Author

I'll need yo debug this to identify. Presently I don't have enough time to get back into it unfortunately. Perhaps try to comment out the code/ member variable that's crashing and work around it. I'll look into it when I get time.

@stelios357
Copy link

I've made a PR against this issue: #28

@ParadoxZero ParadoxZero linked a pull request Dec 20, 2020 that will close this issue
@ParadoxZero
Copy link
Owner Author

@stelios357 I have added some comments. Please go through them when you get a chance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants