Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Can only apply one effect per type to charms #53

Open
UnknownSilicon opened this issue Jun 14, 2023 · 0 comments
Open

[BUG] Can only apply one effect per type to charms #53

UnknownSilicon opened this issue Jun 14, 2023 · 0 comments
Assignees
@UnknownSilicon
Labels
bug Something isn't working Charms

Comments

@UnknownSilicon
Copy link
Member

Describe the bug
It is not possible to apply more than one effect of the same type to a charm.

To Reproduce
Steps to reproduce the behavior:

  1. Create a charm config with two instances of a PLAYER_PARTICLE effect
  2. Apply charm to item
  3. Observe that only one effect is present

Expected behavior
Both effects are present

Additional context
I have no idea why I designed it like this. Basically, it should likely be an ArrayList instead of a HashMap for storing effects, but that might need to be different too.
@UnknownSilicon UnknownSilicon added bug Something isn't working Charms labels Jun 14, 2023
@UnknownSilicon UnknownSilicon self-assigned this Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@UnknownSilicon UnknownSilicon

Labels
bug Something isn't working Charms
Projects
ParallelMC Coders' Corner Board
Status: Backlog
Milestone
No milestone
Development

No branches or pull requests
1 participant
@UnknownSilicon