Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing "using namespace std" #174

Open
Rhialto opened this issue Oct 30, 2022 · 0 comments
Open

Removing "using namespace std" #174

Rhialto opened this issue Oct 30, 2022 · 0 comments

Comments

@Rhialto
Copy link

Rhialto commented Oct 30, 2022

Would you be open to a merge request that removes using namespace std; from ./src/libpar2internal.h? It will also mean to add std:: to all occurrences of string, set, map etc etc, so it is somewhat of a churn. On the other hand, using namespace std; is frowned upon for a long time. The work is not hard but a bit annoying, so I'm asking before I'm actually doing it.

The reason I'm asking is that there is another project (http://gitlab.com:Rhialto/nget) that has incorporated an old copy of par2, and I had to clean its use of std:. Unfortunately, via an include file, the using still leaked into nget code. So I cleaned up the copy, but I might as well offer the same upstream. And I want to look into updating the copied version.

The change would be quite similar to this commit, I'd imagine: https://gitlab.com/Rhialto/nget/-/commit/e305f2d44c6536f72b95084259cac04b50043857

There are a few more cleanup commits I did in the copy of par2; after this I would like to propose them here as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant