Support Unicode and long-paths on Windows #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@animetosho since there's not really a maintainer, maybe you could code review and pull the changes into par2cmdline turbo? |
|
Unfortunately I already stretched myself too thin with par2cmdline-turbo, so I want to stay far away from par2cmdline maintainer duties. Appreciate the work people have put in with pull requests regardless - it goes to show there's still interest in the project. Perhaps this interest could lead to a new maintainer - maybe see if someone else is willing? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for Unicode program arguments and long-paths using the
\\?\prefix on Windows.Also converts filenames to the codepage in use by the console, so if supported won't result in question marks in the output.
The changes should have no affect on non-Windows builds, the utf8::* methods are no-ops.
References to a few useful resources used to arrive at this solution:
Resolves #189